fix: return fake version for performance.timeOrigin
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a nice addition, but |
fatso83
reviewed
Dec 4, 2024
rriski
force-pushed
the
support-performance-timeOrigin
branch
from
aa0a107 to
c67caa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
Purpose (TL;DR) - mandatory
Return valid value for
performance.timeOrigininstead ofNOOP. This fixes an issue in tests that depend onperformance.timeOriginhaving a valid value.Background (Problem in detail) - optional
See #514
Solution - optional
Set
performance.timeOriginto a dummy value. I'm not sure if 0 is better than setting the value toclock.now. When testingperformance.timeOriginin Chrome Console I can see that the value is set to the timestamp when the window was opened:There is further information in MDS docs on how the value is supposed to be set: https://developer.mozilla.org/en-US/docs/Web/API/Performance/timeOrigin#value